Support React 0.15+ / ES2015 / Add mandatory API_KEY / Use little-loader #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've changed the lifecycle hook to DidMount instead of WillMount (that was a typo) |
|
👍 need the apiKey field in there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I really liked this library, and tried to use it - however, it didn't work out of the box. I had some errors with scriptjs / google api (which requires an API_KEY) / react select didn't show any options. I decided to convert it to React 0.15 + ES2015, replace the scriptjs with little-loader, and use a custom code to wait for google api to load, and fix the react select issues.
Please review my changes, and let me know if you want me to do make more changes 👍
*The example won't work without providing an API_KEY.