Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add os.PathLike support to specify CA bundle to use #194

Merged

Conversation

wallseat
Copy link

No description provided.

@wallseat
Copy link
Author

A have no idea how to cover this by tests with current usage of httpbin fixtures.
httpbin_ca_bundle doesn't provide a path, it's just monkeypatching
maybe you have an idea?)

src/niquests/adapters.py Outdated Show resolved Hide resolved
src/niquests/_typing.py Outdated Show resolved Hide resolved
src/niquests/adapters.py Outdated Show resolved Hide resolved
src/niquests/adapters.py Outdated Show resolved Hide resolved
@Ousret
Copy link
Member

Ousret commented Dec 29, 2024

A have no idea how to cover this by tests with current usage of httpbin fixtures.
httpbin_ca_bundle

Use def test_cookie_allow_localhost_default(self, san_server): example. it provides everything you need.

@wallseat wallseat force-pushed the feature/add-pathlib-path-support-for-ca-cert branch from 6751edd to 2e6657a Compare December 29, 2024 17:34
@wallseat wallseat requested a review from Ousret December 29, 2024 17:36
@wallseat wallseat changed the title Add pathlib.Path support to specify CA bundle to use Add os.PathLike support to specify CA bundle to use Dec 30, 2024
@Ousret Ousret force-pushed the feature/add-pathlib-path-support-for-ca-cert branch from b2cf1db to 2f89752 Compare January 1, 2025 19:23
Copy link
Member

@Ousret Ousret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor adjustments made. otherwise LGTM.

@Ousret Ousret mentioned this pull request Jan 1, 2025
@Ousret Ousret merged commit 214dba8 into jawah:main Jan 1, 2025
33 checks passed
Ousret added a commit that referenced this pull request Jan 1, 2025
3.12.0 (2025-01-01)
-------------------

**Fixed**
- Restoring the state of `AsyncSession` through pickle.
- Typing definition for query parameter not accepting `None` as values.
(#193)
- Overload incorrect definition for `AsyncSession::get`. (#192)

**Added**
- Support for `PathLike` objects for `verify` parameter when passing a
ca bundle path. (#194)
- Caching and restoring OCSP state through pickling `Session` or
`AsyncSession`.
- Caching and restoring QUIC known compatible hosts through pickling
`Session` or `AsyncSession`.
- Shortcut convenient access to `Retry` and `Timeout` configuration
objects in top-level import.
@wallseat wallseat deleted the feature/add-pathlib-path-support-for-ca-cert branch January 1, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants