Changes to allow doctrine/dbal 4 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update for doctrine/dbal 4
|
Hi thank you for your pr, please give me some days to check this since I'm really busy right now. |
|
Hello, thank you very much for this PR :) |
|
@knallcharge I just released v1.7.0 with DBAL 4 compatibility, thank you very much for reporting this and for the PR :) |
|
@jawira Thanks for the quick merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to make changes to allow the usage of doctrine/dbal 4.
getName() of Doctrine/Type was removed in dbal 4 (already deprecated in dbal 3), so I replaced it with TypeRegistry::lookup() which should do the job.
I don't know if running Type::getTypeRegistry for each column is a little too much overhead or if this should just be issued once and the object reused, but I didn't dive deep enough into the package to find out the necessary changes - you decide :)
Successfully tested this with one of my projects, please let me know what you think.