prevent that errors are being replicated from signals

breathecode/activity/tests/tasks/tests_get_attendancy_log.py

@@ -7,8 +7,8 @@
 
 from django.utils import timezone
 
-from breathecode.activity.tasks import get_attendancy_log
 from breathecode.activity import tasks
+from breathecode.activity.tasks import get_attendancy_log
 from breathecode.utils import NDB
 
 from ...models import StudentActivity
@@ -45,8 +45,8 @@ class MediaTestSuite(MediaTestCase):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch.object(NDB, 'fetch', MagicMock(return_value=[]))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_not_found(self):
         get_attendancy_log.delay(1)
 
@@ -68,8 +68,8 @@ def test_not_found(self):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch.object(NDB, 'fetch', MagicMock(return_value=[]))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_syllabus_not_found(self):
         with patch('breathecode.activity.tasks.get_attendancy_log.delay', MagicMock()):
             model = self.bc.database.create(cohort=1)
@@ -100,8 +100,8 @@ def test_syllabus_not_found(self):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch.object(NDB, 'fetch', MagicMock(return_value=[]))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_syllabus_version_with_json_with_bad_format(self):
         syllabus_versions = [
             {
@@ -186,9 +186,9 @@ def test_syllabus_version_with_json_with_bad_format(self):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch('django.utils.timezone.now', MagicMock(return_value=UTC_NOW))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock())
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_the_student_attended_the_first_day(self):
         cases = [
             ([get_datastore_seed(self.bc.fake.slug(), 1, {'slug': 'classroom_attendance'})], [], [1], []),
@@ -266,8 +266,8 @@ def test_the_student_attended_the_first_day(self):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch('django.utils.timezone.now', MagicMock(return_value=UTC_NOW))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_the_students_attended_all_days(self):
         cases = [
             ([
@@ -470,8 +470,8 @@ def test_the_students_attended_all_days(self):
     @patch('breathecode.utils.ndb.NDB.__init__', MagicMock(return_value=None))
     @patch('django.utils.timezone.now', MagicMock(return_value=UTC_NOW))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_the_students_attended_all_days__the_days_is_string(self):
         cases = [
             ([
@@ -676,8 +676,8 @@ def test_the_students_attended_all_days__the_days_is_string(self):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch('django.utils.timezone.now', MagicMock(return_value=UTC_NOW))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_the_students_attended_all_days__duration_in_days(self):
         cases = [
             ([
@@ -1079,8 +1079,8 @@ def test_the_students_attended_all_days__duration_in_days(self):
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch('django.utils.timezone.now', MagicMock(return_value=UTC_NOW))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_the_students_attended_all_days__duration_in_days__two_cohort_users(self):
         cases = [
             ([
@@ -1480,9 +1480,9 @@ def test_the_students_attended_all_days__duration_in_days__two_cohort_users(self
     @patch.object(NDB, '__init__', MagicMock(return_value=None))
     @patch('django.utils.timezone.now', MagicMock(return_value=UTC_NOW))
     @patch('breathecode.activity.tasks.get_attendancy_log_per_cohort_user.delay', MagicMock())
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock())
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_the_students_attended_all_days__duration_in_days__two_cohort_users__they_was_deleted(self):
         cases = [
             ([

breathecode/activity/tests/tasks/tests_get_attendancy_log_per_cohort_user.py

@@ -2,14 +2,14 @@
 Test /answer
 """
 import logging
-from datetime import timedelta
 import random
+from datetime import timedelta
 from unittest.mock import MagicMock, call, patch
 
 from django.utils import timezone
 
-from breathecode.activity.tasks import get_attendancy_log_per_cohort_user
 from breathecode.activity import tasks
+from breathecode.activity.tasks import get_attendancy_log_per_cohort_user
 from breathecode.utils import NDB
 
 from ..mixins import MediaTestCase
@@ -43,8 +43,8 @@ class MediaTestSuite(MediaTestCase):
     @patch('logging.Logger.info', MagicMock())
     @patch('logging.Logger.error', MagicMock())
     @patch('breathecode.activity.tasks.get_attendancy_log.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_not_found(self):
         get_attendancy_log_per_cohort_user.delay(1)
 
@@ -62,8 +62,8 @@ def test_not_found(self):
     @patch('logging.Logger.info', MagicMock())
     @patch('logging.Logger.error', MagicMock())
     @patch('breathecode.activity.tasks.get_attendancy_log.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_with_cohort_user(self):
         cohort = {'history_log': random.choice(['', None, {}, []])}
         model = self.bc.database.create(cohort=cohort, cohort_user=1)
@@ -94,8 +94,8 @@ def test_with_cohort_user(self):
     @patch('logging.Logger.info', MagicMock())
     @patch('logging.Logger.error', MagicMock())
     @patch('breathecode.activity.tasks.get_attendancy_log.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_with_cohort_user__user_do_not_assist(self):
         utc_now = timezone.now()
         day1 = str(random.randint(1, 9))
@@ -159,8 +159,8 @@ def test_with_cohort_user__user_do_not_assist(self):
     @patch('logging.Logger.info', MagicMock())
     @patch('logging.Logger.error', MagicMock())
     @patch('breathecode.activity.tasks.get_attendancy_log.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_with_cohort_user__user_assist(self):
         utc_now = timezone.now()
         day1 = str(random.randint(1, 9))
@@ -226,8 +226,8 @@ def test_with_cohort_user__user_assist(self):
     @patch('logging.Logger.info', MagicMock())
     @patch('logging.Logger.error', MagicMock())
     @patch('breathecode.activity.tasks.get_attendancy_log.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_with_cohort_user__with_bad_user_log(self):
         utc_now = timezone.now()
         available_days = {str(random.randint(1, 9)) for _ in range(4)}

breathecode/admissions/actions.py

@@ -207,10 +207,10 @@ def update_asset_on_json(from_slug, to_slug, asset_type, simulate=True):
             s.save()
 
     if not simulate and len(findings) > 0:
-        syllabus_asset_slug_updated.send(sender=update_asset_on_json,
-                                         from_slug=from_slug,
-                                         to_slug=to_slug,
-                                         asset_type=asset_type)
+        syllabus_asset_slug_updated.send_robust(sender=update_asset_on_json,
+                                                from_slug=from_slug,
+                                                to_slug=to_slug,
+                                                asset_type=asset_type)
 
     return findings
 

breathecode/admissions/models.py

@@ -162,7 +162,7 @@ def save(self, *args, **kwargs):
         if created:
             self.__old_slug = self.slug
 
-        academy_saved.send(instance=self, sender=self.__class__, created=created)
+        academy_saved.send_robust(instance=self, sender=self.__class__, created=created)
 
 
 PARTIME = 'PART-TIME'
@@ -259,7 +259,7 @@ def save(self, *args, **kwargs):
 
         super().save(*args, **kwargs)
 
-        if json_modified: syllabus_version_json_updated.send(instance=self, sender=SyllabusVersion)
+        if json_modified: syllabus_version_json_updated.send_robust(instance=self, sender=SyllabusVersion)
 
 
 class SyllabusSchedule(models.Model):
@@ -390,7 +390,7 @@ def save_history_log(self, *args, **kwargs):
 
         super().save(*args, **kwargs)
 
-        signals.cohort_saved.send(instance=self, sender=self.__class__, created=False)
+        signals.cohort_saved.send_robust(instance=self, sender=self.__class__, created=False)
 
         self._current_history_log = self.history_log
 
@@ -406,13 +406,13 @@ def save(self, *args, **kwargs):
 
         super().save(*args, **kwargs)
 
-        signals.cohort_saved.send(instance=self, sender=self.__class__, created=created)
+        signals.cohort_saved.send_robust(instance=self, sender=self.__class__, created=created)
 
         if self.history_log and self.history_log != self._current_history_log:
-            signals.cohort_log_saved.send(instance=self, sender=self.__class__, created=created)
+            signals.cohort_log_saved.send_robust(instance=self, sender=self.__class__, created=created)
 
         if stage_updated:
-            signals.cohort_stage_updated.send(instance=self, sender=self.__class__)
+            signals.cohort_stage_updated.send_robust(instance=self, sender=self.__class__)
 
         self._current_history_log = self.history_log
 
@@ -518,12 +518,12 @@ def save(self, *args, **kwargs):
         result = super().save(*args, **kwargs)  # Call the "real" save() method.
 
         if edu_status_updated:
-            signals.student_edu_status_updated.send(instance=self, sender=self.__class__)
+            signals.student_edu_status_updated.send_robust(instance=self, sender=self.__class__)
 
-        signals.cohort_log_saved.send(instance=self, sender=self.__class__)
+        signals.cohort_log_saved.send_robust(instance=self, sender=self.__class__)
 
         if on_create:
-            signals.cohort_user_created.send(instance=self, sender=self.__class__)
+            signals.cohort_user_created.send_robust(instance=self, sender=self.__class__)
 
         self.__old_edu_status = self.educational_status
 
@@ -597,7 +597,7 @@ def save(self, *args, **kwargs):
         self.full_clean()
         super().save(*args, **kwargs)
 
-        # signals.timeslot_saved.send(instance=self, sender=self.__class__, created=created)
+        # signals.timeslot_saved.send_robust(instance=self, sender=self.__class__, created=created)
 
 
 class CohortTimeSlot(TimeSlot):
@@ -616,4 +616,4 @@ def save(self, *args, **kwargs):
         self.full_clean()
         super().save(*args, **kwargs)
 
-        signals.timeslot_saved.send(instance=self, sender=self.__class__, created=created)
+        signals.timeslot_saved.send_robust(instance=self, sender=self.__class__, created=created)

breathecode/admissions/tests/admin/tests_add_student_tag_to_active_campaign.py

@@ -2,9 +2,12 @@
 Test /cohort/user
 """
 from unittest.mock import MagicMock, call, patch
-from breathecode.admissions.models import CohortUser
-from breathecode.admissions.admin import add_student_tag_to_active_campaign
+
 from django.http.request import HttpRequest
+
+from breathecode.admissions.admin import add_student_tag_to_active_campaign
+from breathecode.admissions.models import CohortUser
+
 from ..mixins import AdmissionsTestCase
 
 
@@ -14,8 +17,8 @@ class CohortUserTestSuite(AdmissionsTestCase):
     """
 
     @patch('breathecode.marketing.tasks.add_cohort_task_to_student.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_add_student_tag_to_active_campaign__zero_cohort_users(self):
         from breathecode.marketing.tasks import add_cohort_task_to_student
 
@@ -31,8 +34,8 @@ def test_add_student_tag_to_active_campaign__zero_cohort_users(self):
     """
 
     @patch('breathecode.marketing.tasks.add_cohort_task_to_student.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_add_student_tag_to_active_campaign__one_cohort_user(self):
         from breathecode.marketing.tasks import add_cohort_task_to_student
 
@@ -52,8 +55,8 @@ def test_add_student_tag_to_active_campaign__one_cohort_user(self):
     """
 
     @patch('breathecode.marketing.tasks.add_cohort_task_to_student.delay', MagicMock())
-    @patch('django.db.models.signals.pre_delete.send', MagicMock(return_value=None))
-    @patch('breathecode.admissions.signals.student_edu_status_updated.send', MagicMock(return_value=None))
+    @patch('django.db.models.signals.pre_delete.send_robust', MagicMock(return_value=None))
+    @patch('breathecode.admissions.signals.student_edu_status_updated.send_robust', MagicMock(return_value=None))
     def test_add_student_tag_to_active_campaign__two_cohort_users(self):
         from breathecode.marketing.tasks import add_cohort_task_to_student