Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chapter skipping support to exoplayer client #1533

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CeruleanRed
Copy link

@CeruleanRed CeruleanRed commented Dec 30, 2024

Changes
Added buttons to support chapter skipping in the exoplayer client. Buttons are only present if chapters actually exist on the file being played. Button behaviour was modeled on how the web client works (e.g. the 10s interval in which going back a chapter results in going to the previous chapter, instead of starting the current one at 0)

Images

(Ignore the video quality, it's trying to software decode AV1 on the emulator)
image

Extra comments

  • Currently when hiding the skip chapter buttons, there is a slight lag until the buttons disappear due to having to check if chapters exist, which can only happen when the media is loaded. Any alternative that improves this would be welcome.
  • The "watched" status of the chapter markings only updates after the user has let go of the thumb when scrubbing

Fixes
#155

@jellyfin-bot jellyfin-bot added this to the v2.7.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants