Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid cookie parsing for the "=" character #271

Merged
merged 1 commit into from
Jun 9, 2024

Conversation

qgolsteyn
Copy link
Contributor

@qgolsteyn qgolsteyn commented Jun 9, 2024

Change:

  • Addresses the invalid cookie parse when the cookie value contains a "=".
  • Add a test to ensure the cookie parsing logic supports the entire ASCII character set, minus semi-colon, comma, backslash, percent, and white space.

Closes #269

Note:
I stumbled on another issue regarding cookie parsing while working on this PR. I opened an issue here: #270

@naorpeled
Copy link
Collaborator

Hey,
first of all thanks! You're AWSome.

I'll give the issue you've raised some thought.
Regarding the tests that are failing in Node 14, if there's an easy fix let's implement it. Otherwise, we might just drop Node 14 support as it already reached its EOL

@qgolsteyn
Copy link
Contributor Author

Fingers crossed this should address both the Node v14 issue and pass the Prettier check

Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for this, you rock!

@naorpeled naorpeled merged commit b2eb0a2 into jeremydaly:main Jun 9, 2024
6 checks passed
@naorpeled
Copy link
Collaborator

Will publish a new release tomorrow 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Library does not parse cookie values containing '=' correctly
2 participants