Skip to content

Commit

Permalink
Fix a printf warning for CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
jeroen committed Dec 4, 2023
1 parent 36f49be commit d2e2f22
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: V8
Type: Package
Title: Embedded JavaScript and WebAssembly Engine for R
Version: 4.4.0
Version: 4.4.1
Authors@R: c(
person("Jeroen", "Ooms", role = c("aut", "cre"), email = "[email protected]",
comment = c(ORCID = "0000-0002-4035-0289")),
Expand Down
3 changes: 3 additions & 0 deletions NEWS
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
4.4.1
- Fix a printf warning for CRAN

4.4.0
- Windows (R-4.3 and up): update libv8 to 11.8.172.13 + arm64 support.

Expand Down
2 changes: 1 addition & 1 deletion src/bindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ static void ConsoleWarn(const v8::FunctionCallbackInfo<v8::Value>& args) {
for (int i=0; i < args.Length(); i++) {
v8::HandleScope handle_scope(args.GetIsolate());
v8::String::Utf8Value str(args.GetIsolate(), args[i]);
Rf_warningcall_immediate(R_NilValue, ToCString(str));
Rf_warningcall_immediate(R_NilValue, "%s", ToCString(str));
}
//args.GetReturnValue().Set(v8::Undefined(args.GetIsolate()));
}
Expand Down

0 comments on commit d2e2f22

Please sign in to comment.