Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: encoding options added #359

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Conversation

pgradoboev
Copy link
Contributor

@pgradoboev pgradoboev commented Dec 13, 2024

James, please look at the proposed changes. #358

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 86.628% (+0.1%) from 86.507%
when pulling c65b6d3 on pgradoboev:encoding-options
into 1d9fc9c on jhillyerd:main.

Copy link
Owner

@jhillyerd jhillyerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like adding the Encoder options.

I don't accept PRs without tests, as subsequent PRs to the same code often end up breaking or reverting that feature. Take a look at this test as a possible starting point:

func TestEncodePartContentBinary(t *testing.T) {

encoder_options.go Outdated Show resolved Hide resolved
encoder_options.go Outdated Show resolved Hide resolved
encode.go Show resolved Hide resolved
@pgradoboev pgradoboev marked this pull request as draft December 28, 2024 06:02
@jhillyerd
Copy link
Owner

Looks pretty good to me, not sure if you're ready for review since it's still marked as draft?

@pgradoboev
Copy link
Contributor Author

James, I wanted to add more tests after the holidays. But if you think that's enough, then I've changed the request status.

@pgradoboev pgradoboev marked this pull request as ready for review January 6, 2025 18:04
Signed-off-by: James Hillyerd <[email protected]>
Copy link
Owner

@jhillyerd jhillyerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a tweak to the test to check a bit of the encoded content.

@jhillyerd jhillyerd merged commit 83dff18 into jhillyerd:main Jan 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants