Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle spaces inside angle brackets #360

Merged
merged 1 commit into from
Jan 5, 2025
Merged

fix: Handle spaces inside angle brackets #360

merged 1 commit into from
Jan 5, 2025

Conversation

dflse
Copy link
Contributor

@dflse dflse commented Jan 2, 2025

closes #339

@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Coverage Status

coverage: 86.547% (+0.04%) from 86.507%
when pulling 2e50828 on dflse:main
into 1d9fc9c on jhillyerd:main.

jhillyerd
jhillyerd requested changes Jan 3, 2025
View reviewed changes
Copy link
Owner

@jhillyerd jhillyerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one change

internal/stringutil/addr.go Outdated
inDomain = false
sb.WriteRune(',')
sb.WriteRune(r)
continue
}
}

if inAngles {
if r == ' ' {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just use && for these two ifs

@dflse dflse requested a review from jhillyerd January 5, 2025 10:07
@jhillyerd jhillyerd merged commit 50133b8 into jhillyerd:main Jan 5, 2025
9 checks passed
@jhillyerd
Copy link
Owner

Thanks!

@iredmail
Copy link
Contributor

iredmail commented Jan 6, 2025

Thanks @dflse :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhillyerd jhillyerd jhillyerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to handle these From: values?
5 participants
@dflse @coveralls @jhillyerd @iredmail @Flassie