Removed final lint errors

jirogit · Jan 7, 2024 · fa26031 · fa26031
1 parent 5187625
commit fa26031
Show file tree

Hide file tree

Showing 30 changed files with 139 additions and 108 deletions.
diff --git a/src/components/Map/CreateWaypointDialog.tsx b/src/components/Map/CreateWaypointDialog.tsx
@@ -71,6 +71,7 @@ export const CreateWaypointDialog = ({
   lngLat,
   closeDialog,
   existingWaypoint,
+  // biome-ignore lint/complexity/noExcessiveCognitiveComplexity: Functional component
 }: ICreateWaypointDialogProps) => {
   const { t } = useTranslation();
 
@@ -175,7 +176,7 @@ export const CreateWaypointDialog = ({
 
   const flyToPosition = useMemo(
     () => (pos: LngLat) => map?.flyTo(getFlyToConfig(pos)),
-    [getFlyToConfig, map],
+    [map],
   );
 
   const handlePositionUpdate = useMemo(
@@ -184,7 +185,7 @@ export const CreateWaypointDialog = ({
         setWaypointPosition(e.lngLat);
         flyToPosition(e.lngLat);
       }, 300),
-    [map],
+    [flyToPosition],
   );
 
   const encodeEmoji = (emoji: string | null): number => {

diff --git a/src/components/Map/MapView.tsx b/src/components/Map/MapView.tsx
@@ -129,7 +129,7 @@ export const MapView = () => {
     }, 5000); // 5s
 
     return () => clearInterval(timeout);
-  }, []);
+  }, [dispatch]);
 
   const layers = useMemo(
     () => [
@@ -193,8 +193,6 @@ export const MapView = () => {
     [
       nodesFeatureCollection,
       edgesFeatureCollection,
-      setNodeHoverInfo,
-      setEdgeHoverInfo,
       handleNodeClick,
       activeNodeId,
     ],

diff --git a/src/components/Map/algorithms/Chart.tsx b/src/components/Map/algorithms/Chart.tsx
@@ -35,6 +35,7 @@ export const options = {
   },
 };
 
+// biome-ignore lint/complexity/noExcessiveCognitiveComplexity: Component needs to be rewritten
 function convertToDataFormat() {
   // data: Map<string, Map<string, Map<string, number>>>
   const diffcen = {

diff --git a/src/components/config/ConfigInput.tsx b/src/components/config/ConfigInput.tsx
@@ -15,6 +15,7 @@ export interface IConfigInputProps
 
 export const ConfigInput = forwardRef<
   HTMLInputElement,
+  // biome-ignore lint/suspicious/noExplicitAny: Need any to simplify complexity of being config-agnostic
   IConfigInputProps & ReturnType<UseFormRegister<any>>
 >(({ text, error, ...rest }, ref) => {
   return (

diff --git a/src/components/config/ConfigSelect.tsx b/src/components/config/ConfigSelect.tsx
@@ -15,6 +15,7 @@ export interface IConfigSelectProps
 
 export const ConfigSelect = forwardRef<
   HTMLSelectElement,
+  // biome-ignore lint/suspicious/noExplicitAny: Need any to simplify complexity of being config-agnostic
   IConfigSelectProps & ReturnType<UseFormRegister<any>>
 >(({ text, error, ...rest }, ref) => {
   return (

diff --git a/src/components/config/channel/ChannelConfigDetail.tsx b/src/components/config/channel/ChannelConfigDetail.tsx
@@ -70,7 +70,7 @@ export const ChannelConfigDetail = ({
         currentConfig ?? undefined,
         editedConfig ?? undefined,
       ),
-    [],
+    [currentConfig, editedConfig],
   );
 
   const updateStateFlags = (d: DeepPartial<ChannelConfigInput>) => {
@@ -80,7 +80,7 @@ export const ChannelConfigDetail = ({
   useEffect(() => {
     if (!defaultValues) return;
     updateStateFlags(defaultValues);
-  }, [defaultValues]);
+  }, [updateStateFlags, defaultValues]);
 
   const {
     register,
@@ -106,14 +106,15 @@ export const ChannelConfigDetail = ({
         500,
         { leading: true },
       ),
-    [],
+    [dispatch, updateStateFlags, channelNum],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentMeshChannel) return;

diff --git a/src/components/config/device/BluetoothConfigPage.tsx b/src/components/config/device/BluetoothConfigPage.tsx
@@ -60,7 +60,7 @@ export const BluetoothConfigPage = ({
         device?.config.bluetooth ?? undefined,
         editedConfig.bluetooth ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const updateStateFlags = (d: DeepPartial<BluetoothConfigInput>) => {
@@ -71,7 +71,7 @@ export const BluetoothConfigPage = ({
   useEffect(() => {
     if (!defaultValues) return;
     updateStateFlags(defaultValues);
-  }, [defaultValues]);
+  }, [updateStateFlags, defaultValues]);
 
   const {
     register,
@@ -93,14 +93,15 @@ export const BluetoothConfigPage = ({
         500,
         { leading: true },
       ),
-    [],
+    [dispatch, updateStateFlags],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.bluetooth) return;

diff --git a/src/components/config/device/DeviceConfigPage.tsx b/src/components/config/device/DeviceConfigPage.tsx
@@ -50,7 +50,7 @@ export const DeviceConfigPage = ({
         device?.config.device ?? undefined,
         editedConfig.device ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const {
@@ -72,14 +72,15 @@ export const DeviceConfigPage = ({
         500,
         { leading: true },
       ),
-    [],
+    [dispatch],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.device) return;

diff --git a/src/components/config/device/DisplayConfigPage.tsx b/src/components/config/device/DisplayConfigPage.tsx
@@ -55,7 +55,7 @@ export const DisplayConfigPage = ({
         device?.config.display ?? undefined,
         editedConfig.display ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const {
@@ -77,14 +77,15 @@ export const DisplayConfigPage = ({
         500,
         { leading: true },
       ),
-    [],
+    [dispatch],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.display) return;

diff --git a/src/components/config/device/LoRaConfigPage.tsx b/src/components/config/device/LoRaConfigPage.tsx
@@ -62,7 +62,7 @@ export const LoRaConfigPage = ({ className = "" }: ILoRaConfigPageProps) => {
         device?.config.lora ?? undefined,
         editedConfig.lora ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const updateStateFlags = (d: DeepPartial<LoRaConfigInput>) => {
@@ -73,7 +73,7 @@ export const LoRaConfigPage = ({ className = "" }: ILoRaConfigPageProps) => {
   useEffect(() => {
     if (!defaultValues) return;
     updateStateFlags(defaultValues);
-  }, [defaultValues]);
+  }, [updateStateFlags, defaultValues]);
 
   const {
     register,
@@ -95,14 +95,15 @@ export const LoRaConfigPage = ({ className = "" }: ILoRaConfigPageProps) => {
         500,
         { leading: true },
       ),
-    [],
+    [dispatch, updateStateFlags],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.lora) return;

diff --git a/src/components/config/device/NetworkConfigPage.tsx b/src/components/config/device/NetworkConfigPage.tsx
@@ -56,7 +56,7 @@ export const NetworkConfigPage = ({
         device?.config.network ?? undefined,
         editedConfig.network ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const updateStateFlags = (d: DeepPartial<NetworkConfigInput>) => {
@@ -67,7 +67,7 @@ export const NetworkConfigPage = ({
   useEffect(() => {
     if (!defaultValues) return;
     updateStateFlags(defaultValues);
-  }, [defaultValues]);
+  }, [updateStateFlags, defaultValues]);
 
   const {
     register,
@@ -89,14 +89,15 @@ export const NetworkConfigPage = ({
         500,
         { leading: true },
       ),
-    [],
+    [dispatch, updateStateFlags],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.network) return;

diff --git a/src/components/config/device/PositionConfigPage.tsx b/src/components/config/device/PositionConfigPage.tsx
@@ -70,7 +70,7 @@ export const PositionConfigPage = ({
         device?.config.position ?? undefined,
         editedConfig.position ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const updateStateFlags = (d: DeepPartial<PositionConfigInput>) => {
@@ -81,7 +81,7 @@ export const PositionConfigPage = ({
   useEffect(() => {
     if (!defaultValues) return;
     updateStateFlags(defaultValues);
-  }, [defaultValues]);
+  }, [updateStateFlags, defaultValues]);
 
   const {
     register,
@@ -103,14 +103,15 @@ export const PositionConfigPage = ({
         500,
         { leading: true },
       ),
-    [],
+    [dispatch, updateStateFlags],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.position) return;

diff --git a/src/components/config/device/PowerConfigPage.tsx b/src/components/config/device/PowerConfigPage.tsx
@@ -55,7 +55,7 @@ export const PowerConfigPage = ({ className = "" }: IPowerConfigPageProps) => {
         device?.config.power ?? undefined,
         editedConfig.power ?? undefined,
       ),
-    [],
+    [device, editedConfig],
   );
 
   const {
@@ -77,14 +77,15 @@ export const PowerConfigPage = ({ className = "" }: IPowerConfigPageProps) => {
         500,
         { leading: true },
       ),
-    [],
+    [dispatch],
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.power) return;

diff --git a/src/components/config/module/AudioConfigPage.tsx b/src/components/config/module/AudioConfigPage.tsx
@@ -58,7 +58,7 @@ const AudioConfigPage = ({ className = "" }: IAudioConfigPageProps) => {
         undefined,
         // editedConfig.audio ?? undefined
       ),
-    [],
+    [device],
   );
 
   const updateStateFlags = (d: DeepPartial<AudioModuleConfigInput>) => {
@@ -68,7 +68,7 @@ const AudioConfigPage = ({ className = "" }: IAudioConfigPageProps) => {
   useEffect(() => {
     if (!defaultValues) return;
     updateStateFlags(defaultValues);
-  }, [defaultValues]);
+  }, [updateStateFlags, defaultValues]);
 
   const {
     register,
@@ -91,14 +91,15 @@ const AudioConfigPage = ({ className = "" }: IAudioConfigPageProps) => {
         500,
         { leading: true },
       ),
-    [],
+    [updateStateFlags], // dispatch
   );
 
+  watch(updateConfigHander);
+
+  // Cancel handlers when unmounting
   useEffect(() => {
     return () => updateConfigHander.cancel();
-  }, []);
-
-  watch(updateConfigHander);
+  }, [updateConfigHander]);
 
   const handleFormReset = () => {
     if (!currentConfig?.audio) return;