Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sync #42

Merged
merged 3 commits into from
Aug 6, 2024
Merged

update sync #42

merged 3 commits into from
Aug 6, 2024

Conversation

jkool702
Copy link
Owner

@jkool702 jkool702 commented Aug 6, 2024

Summary by Sourcery

Update the shell script formatting workflow to disable checkbashisms and enhance the hyperfine benchmark script by adding a shebang for improved portability.

Enhancements:

  • Add shebang to the hyperfine benchmark script for better portability.

CI:

  • Disable checkbashisms in the shell script formatting workflow.

Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024

Reviewer's Guide by Sourcery

This pull request updates the shell script configurations in the GitHub workflow and adds a shebang line to the hyperfine benchmark script. Specifically, it disables 'sh_checker_checkbashisms_enable' and excludes 'OLD' in the workflow configuration, and ensures the benchmark script is executed with the correct interpreter.

File-Level Changes

Files Changes
.github/workflows/sh-format.yml
hyperfine_benchmark/forkrun.speedtest.hyperfine.bash
Updated shell script configurations and added a shebang line to a benchmark script.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jkool702 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jkool702 jkool702 merged commit 57e4b49 into forkrun_testing Aug 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant