warning: item in documentation is missing backticks --> nes/nes_memory/src/lib.rs:57:47 | 57 | /// This should be called after every CPU tick(). If it returns true the CPU | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: requested on the command line with `-W clippy::doc-markdown` help: try | 57 | /// This should be called after every CPU `tick()`. If it returns true the CPU | ~~~~~~~~

warning: fields `nes`, `cart_ram`, and `last_read` are never read --> nes/nes_memory/src/lib.rs:31:5 | 30 | pub struct NESMemory { | --------- fields in this struct 31 | nes: NES, | ^^^ 32 | cart_ram: bool, | ^^^^^^^^ ... 37 | last_read: RefCell<u8>, | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `dest` --> nes/nes_memory/src/lib.rs:120:19 | 120 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) { | ^^^^ help: if this is intentional, prefix it with an underscore: `_dest` | = note: `#[warn(unused_variables)]` on by default

warning: field `ram` is never read --> nes/apu/src/lib.rs:9:5 | 8 | pub struct APU { | --- field in this struct 9 | ram: [u8; 0x18], | ^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `dest` --> nes/apu/src/lib.rs:42:19 | 42 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) { | ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`

warning: unused variable: `val` --> nes/apu/src/lib.rs:31:36 | 31 | fn write(&mut self, addr: u16, val: u8) { | ^^^ help: if this is intentional, prefix it with an underscore: `_val` | = note: `#[warn(unused_variables)]` on by default

warning: methods `ppu_read` and `ppu_write` are never used --> nes/ppu/src/lib.rs:91:8 | 64 | impl PPU { | -------- methods in this implementation ... 91 | fn ppu_read(&self, addr: u16) -> u8 { | ^^^^^^^^ ... 99 | fn ppu_write(&mut self, addr: u16, val: u8) { | ^^^^^^^^^

warning: fields `mapper` and `pallete_ram` are never read --> nes/ppu/src/lib.rs:9:5 | 8 | pub struct PPU { | --- fields in this struct 9 | mapper: Box<dyn PPUMapper>, | ^^^^^^ 10 | pallete_ram: [u8; 0x20], | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `dest` --> nes/ppu/src/lib.rs:59:19 | 59 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) { | ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`

warning: unused variable: `val` --> nes/ppu/src/lib.rs:48:36 | 48 | fn write(&mut self, addr: u16, val: u8) { | ^^^ help: if this is intentional, prefix it with an underscore: `_val` | = note: `#[warn(unused_variables)]` on by default

warning: item in documentation is missing backticks --> nes/nes_memory/src/lib.rs:57:47 | 57 | /// This should be called after every CPU tick(). If it returns true the CPU | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown = note: requested on the command line with `-W clippy::doc-markdown` help: try | 57 | /// This should be called after every CPU `tick()`. If it returns true the CPU | ~~~~~~~~

warning: fields `nes`, `cart_ram`, and `last_read` are never read --> nes/nes_memory/src/lib.rs:31:5 | 30 | pub struct NESMemory { | --------- fields in this struct 31 | nes: NES, | ^^^ 32 | cart_ram: bool, | ^^^^^^^^ ... 37 | last_read: RefCell<u8>, | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `dest` --> nes/nes_memory/src/lib.rs:120:19 | 120 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) { | ^^^^ help: if this is intentional, prefix it with an underscore: `_dest` | = note: `#[warn(unused_variables)]` on by default

warning: field `ram` is never read --> nes/apu/src/lib.rs:9:5 | 8 | pub struct APU { | --- field in this struct 9 | ram: [u8; 0x18], | ^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `dest` --> nes/apu/src/lib.rs:42:19 | 42 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) { | ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`

warning: unused variable: `val` --> nes/apu/src/lib.rs:31:36 | 31 | fn write(&mut self, addr: u16, val: u8) { | ^^^ help: if this is intentional, prefix it with an underscore: `_val` | = note: `#[warn(unused_variables)]` on by default

warning: methods `ppu_read` and `ppu_write` are never used --> nes/ppu/src/lib.rs:91:8 | 64 | impl PPU { | -------- methods in this implementation ... 91 | fn ppu_read(&self, addr: u16) -> u8 { | ^^^^^^^^ ... 99 | fn ppu_write(&mut self, addr: u16, val: u8) { | ^^^^^^^^^

warning: fields `mapper` and `pallete_ram` are never read --> nes/ppu/src/lib.rs:9:5 | 8 | pub struct PPU { | --- fields in this struct 9 | mapper: Box<dyn PPUMapper>, | ^^^^^^ 10 | pallete_ram: [u8; 0x20], | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unused variable: `dest` --> nes/ppu/src/lib.rs:59:19 | 59 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) { | ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`

warning: unused variable: `val` --> nes/ppu/src/lib.rs:48:36 | 48 | fn write(&mut self, addr: u16, val: u8) { | ^^^ help: if this is intentional, prefix it with an underscore: `_val` | = note: `#[warn(unused_variables)]` on by default

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.