Start of implementation for NES memory bus #672
clippy
10 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 10 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.80.0 (051478957 2024-07-21)
- cargo 1.80.0 (376290515 2024-07-16)
- clippy 0.1.80 (0514789 2024-07-21)
Annotations
Check warning on line 57 in nes/nes_memory/src/lib.rs
github-actions / clippy
item in documentation is missing backticks
warning: item in documentation is missing backticks
--> nes/nes_memory/src/lib.rs:57:47
|
57 | /// This should be called after every CPU tick(). If it returns true the CPU
| ^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown
= note: requested on the command line with `-W clippy::doc-markdown`
help: try
|
57 | /// This should be called after every CPU `tick()`. If it returns true the CPU
| ~~~~~~~~
Check warning on line 31 in nes/nes_memory/src/lib.rs
github-actions / clippy
fields `nes`, `cart_ram`, and `last_read` are never read
warning: fields `nes`, `cart_ram`, and `last_read` are never read
--> nes/nes_memory/src/lib.rs:31:5
|
30 | pub struct NESMemory {
| --------- fields in this struct
31 | nes: NES,
| ^^^
32 | cart_ram: bool,
| ^^^^^^^^
...
37 | last_read: RefCell<u8>,
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 120 in nes/nes_memory/src/lib.rs
github-actions / clippy
unused variable: `dest`
warning: unused variable: `dest`
--> nes/nes_memory/src/lib.rs:120:19
|
120 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 91 in nes/ppu/src/lib.rs
github-actions / clippy
methods `ppu_read` and `ppu_write` are never used
warning: methods `ppu_read` and `ppu_write` are never used
--> nes/ppu/src/lib.rs:91:8
|
64 | impl PPU {
| -------- methods in this implementation
...
91 | fn ppu_read(&self, addr: u16) -> u8 {
| ^^^^^^^^
...
99 | fn ppu_write(&mut self, addr: u16, val: u8) {
| ^^^^^^^^^
Check warning on line 9 in nes/ppu/src/lib.rs
github-actions / clippy
fields `mapper` and `pallete_ram` are never read
warning: fields `mapper` and `pallete_ram` are never read
--> nes/ppu/src/lib.rs:9:5
|
8 | pub struct PPU {
| --- fields in this struct
9 | mapper: Box<dyn PPUMapper>,
| ^^^^^^
10 | pallete_ram: [u8; 0x20],
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 59 in nes/ppu/src/lib.rs
github-actions / clippy
unused variable: `dest`
warning: unused variable: `dest`
--> nes/ppu/src/lib.rs:59:19
|
59 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`
Check warning on line 48 in nes/ppu/src/lib.rs
github-actions / clippy
unused variable: `val`
warning: unused variable: `val`
--> nes/ppu/src/lib.rs:48:36
|
48 | fn write(&mut self, addr: u16, val: u8) {
| ^^^ help: if this is intentional, prefix it with an underscore: `_val`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 9 in nes/apu/src/lib.rs
github-actions / clippy
field `ram` is never read
warning: field `ram` is never read
--> nes/apu/src/lib.rs:9:5
|
8 | pub struct APU {
| --- field in this struct
9 | ram: [u8; 0x18],
| ^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 42 in nes/apu/src/lib.rs
github-actions / clippy
unused variable: `dest`
warning: unused variable: `dest`
--> nes/apu/src/lib.rs:42:19
|
42 | fn ram(&self, dest: &mut [u8; memory::MAX_SIZE]) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_dest`
Check warning on line 31 in nes/apu/src/lib.rs
github-actions / clippy
unused variable: `val`
warning: unused variable: `val`
--> nes/apu/src/lib.rs:31:36
|
31 | fn write(&mut self, addr: u16, val: u8) {
| ^^^ help: if this is intentional, prefix it with an underscore: `_val`
|
= note: `#[warn(unused_variables)]` on by default