Added device with deviceInfo based on device name, type, model and firmware version #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del is derived from the controller, if new get_model function is available (otherwise it's none / unknown)
|
It would be nicer if the airconwithme device would return the same model (instead of the modelId 550) but that would need a mapping in pyIntesishome from ModelId to modelname. |
This needs an update to pyintesishome to get the firmware version of the device (or wifi controller) from the API. So far this seems only to be supported for intesishome_local devices and will return None for all others.
srkoster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change creates a device per entity with the device name, it's type (based on the sub integration type: airconwithme / intesishome_local as manufacturer) and the model. Model is derived from the controller, if new get_model function (see jnimmo/pyIntesisHome#59) is available (otherwise it's none / unknown). Firmware version is derived from the controller for intesishome device, if new get_fw_version function is available (see jnimmo/pyIntesisHome#59) otherwise it's none.
Devices view:
Per device:
New function in pyIntesishome unavailable:
Also change
update_before_add=Truetoupdate_before_add=Falseinasync_setup_entryto prevent issues during startup when using multiple airconwithme devices.