handle a few 'edge cases' for index lookups #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrehm
approved these changes
Nov 23, 2023
| @@ -18,7 +18,7 @@ object DebugDump { | |||
| } | |||
| } | |||
|
|
|||
| def debugDump(g: Graph): String = { | |||
| def apply(g: Graph): String = { | |||
There was a problem hiding this comment.
I generally prefer descriptive function names to apply; both for better code reading and for better experience searching for uses. (searching for uses of apply cannot be done via grep, and tends to be slow in intellij).
If you dislike DebugDump.debugDump(g) we could instead import ...DebugDump.debugDump?
There was a problem hiding this comment.
ok, changed to import ...DebugDump.debugDump
| this.closed = true | ||
|
|
||
| storagePathMaybe.foreach { storagePath => | ||
| println(s"closing graph: writing to storage at `$storagePath`") |
There was a problem hiding this comment.
logger.debug or logger.info? Or //fixme: use proper log message
There was a problem hiding this comment.
i was being lazy, thanks for stopping me. just changed it for slf4j-api
most importantly don't crash and burn if asking for an undefined property, or for schema-conform property that simply isn't used yet
mpollmeier
force-pushed
the
michael/index-lookups-handle-edgecases
branch
from
3340437 to
5f545e4
Compare
delete-merged-branch
bot
deleted the
michael/index-lookups-handle-edgecases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most importantly don't crash and burn if asking for an undefined property,
or for schema-conform property that simply isn't used yet