Add ability to inject custom calendar with backward compatibility #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue :
I needed to update few calendar's property e.g. firstWeekday, because JTDateHelper was returning non mutable calendar object , i was not able to do so.
Solution proposing
As JTDateHelper is having three instance variable , NSCalendar, NSLocale and NSTimeZone, but only 2 are available to inject.
There can always be a need to update some properties of NSCalendar and hence I added ability to inject full calendar object itself with maintaining the backward compatibility of current code.