Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bailouts #120

Open
wants to merge 5 commits into
base: 2.0-dev
Choose a base branch
from
Open

Improve bailouts #120

wants to merge 5 commits into from

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Oct 9, 2023

Re-opens #109 which was merged in error

Improves error handling in cases such as joomla/joomla-cms#38524 where we boot a web application from the cli. Clearly in this case we shouldn't try and form a mis-shaped URL. And from a framework perspective - if we can't find a host then it likely makes sense to bail early rather than miss a domain in a web app's primary url

Summary of Changes

So none of the tests actually have a http host. so most fail where we create a concrete instance. But in a way that shows how our behaviour is kinda unexpected. Should we fail if we can't parse a url. or try and continue. if we try and continue should we set these properties??

Testing Instructions

Code Review

Documentation Changes Required

Not really

@rdeutz
Copy link

rdeutz commented Aug 7, 2024

This here is so old that the drone log are deleted, I would like to see passing tests before we think about merging :-)

@wilsonge
Copy link
Contributor Author

wilsonge commented Sep 9, 2024

Good luck. Pretty much all tests fail because we're testing web apps from the CLI.... We can mock the full thing but I'm not going to try and fix every single test in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants