Reduce app size #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is never used anywhere in the app, so keeping it is pointless.
We only use libsu for running simple shell commands that are guaranteed to be present everywhere; there's no need to include Java I/O interfaces or full Busybox executables.
There's really no reason to leave these features disabled and lose out on significant app size improvements, since there's only one method in the overdraw test that needs special treatment.
There's no reason to include such high-quality images direct from the original camera, since they'll be downscaled to 100x100 dp before being rendered anyway. These images are the primary cause of the massive APK size. This commit downscales the images to a width of 512 and height proportional to the original to preserve aspect ratio. jpegoptim has also been used to strip EXIF metadata and reduce size further by recompressing the image data at a quality of 80.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the signed release APK size down from 14 MB to 2 MB, which is much more reasonable for a small and simple benchmark app like this.