fix_has_ohlcv_305 #426
Merged
fix_has_ohlcv_305 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a fallback refined search using "." prefix if multiple columns found modified "getters" to use has(which = TRUE) to reuse search code
added word boundaries to regex for safer searches
added tests
|
fixed tests and fixed some more edge cases |
|
Thanks for all your work! The tests fail because 'tests/test_has.R' does not contain a |
removed blatant duplicates reordered from core to edge removed dependencies between tests
|
the diff on the pr is a bit messy, but the test_has.R now has a cleaner flow and no blatant duplicates, which i think sets ups better for future work |
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a fallback refined search using "." prefix if multiple columns found. possible this should be the primary path
modified "getters" to use has(which = TRUE) to reuse search code
fixes #305