Updated getSymbols.MySQL SELECT statement to include dbname variable … #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate in database call. Added backticks to getSymbols.MySQL SELECT statement, fixes error retrieving symbols with same name as SQL operators.
| @@ -631,7 +631,13 @@ function(Symbols,env,return.class='xts', | |||
| if(verbose) { | |||
| cat(paste('Loading ',Symbols[[i]],paste(rep('.',10-nchar(Symbols[[i]])),collapse=''),sep='')) | |||
| } | |||
| query <- paste("SELECT ",paste(db.fields,collapse=',')," FROM ",Symbols[[i]]," ORDER BY date") | |||
There was a problem hiding this comment.
Adding the backticks would have been cleaner as:
query <- paste("SELECT ",paste(db.fields,collapse=',')," FROM `",Symbols[[i]],"` ORDER BY date",sep="")It would also be good to separate this change from the change that adds the from and to arguments by putting them in different commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when specifying table. Resolves issue with tables named after MySQL operators (eg. ADD). Triggered by an issue working with Australian Stock Exchange data that contains the ADD symbol.
EDIT 2016-07-19: This pull contains two changes-
Branch commit history has been squashed/rebased for merge.