This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
Dependency for fedora, addition in "README.md" #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using parent.width with QML Layout results in a bad time. Change the hiearchy to Layout controls.
Explicitly import the local namespace to avoid the name collision with QtQuick.Controls types.
Implement system tray compatible representation. Headers are split into tabbed views.
It is valid for a sensor to have an integer value 0 which was evaluating to false. The vendor check should return false if there is no value reported at all for the sensor. In other words an undefined value.
It's too messy to parse sensor names as arguments.
The read_sensor function is pre-generated instead of dynamic calls to eval. So it's not necessary anymore to check if the sensor name is valid.
Assign the variable before signalling the view is ready.
Reproducing: Start with empty pstate.conf Create new profile. Set profile name. e.g. "Default" Click "Save" Profile isn't saved to pstate.conf
This reverts commit 8a8313b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you for taking over this project !! 👍
I just installed it on my fedora 35 KDE and it works fine.👍
However, I searched for a while for the necessary dependencies for its installation. 😥
It would be great to add this command to install the necessary dependencies for Fedora in the "README.md" 😉
sudo yum install cmake gcc extra-cmake-modules kf5-plasma-devel kf5-ki18n-devel qt5-qtdeclarative-develThanks! 🙂