Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in the contributing guidelines to improve onboarding #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Dec 27, 2024

This PR includes some changes in the global contributing guidelines to improve the onboarding of new users.

Related json-schema-org/community#849

CONTRIBUTING.md Outdated
* [JSON Schema Conference](https://github.com/json-schema-org/conference/blob/main/CONTRIBUTING.md).
* [Tour of JSON Schema](https://github.com/json-schema-org/tour/blob/main/CONTRIBUTING.md).
* [JSON Schema Landscape](https://github.com/json-schema-org/landscape/blob/main/CONTRIBUTING.md).
* [JSON Schema Ecosystem](https://github.com/json-schema-org/ecosystem).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link for JSON Schema Ecosystem should follow the format for the other projects i.e referencing the contributing.md file "https://github.com/json-schema-org/landscape/blob/main/CONTRIBUTING.md" OR if there's a reason why we are referencing "https://github.com/json-schema-org/ecosystem", then this implementation is okay.

CONTRIBUTING.md Outdated
* [JSON Schema Ecosystem](https://github.com/json-schema-org/ecosystem).

* 🌐 Other JSON Schema Ecosystem Projects you can contribute to:
* [Bowtie](https://github.com/bowtie-json-schema/bowtie) development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we calling out bowtie specifically but only referring to (and also not linking to) "other tools"?

Copy link
Collaborator Author

@benjagm benjagm Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we calling out bowtie specifically but only referring to (and also not linking to) "other tools"?

That is a great question. I have been pushing for a standard agreement about reaching a common understanding of what means "critical JSON Schema projects" and what those are, but the issue with that discussion is still ongoing json-schema-org/TSC#5. Happy to add here other critical projects like alterschema.

In terms of implementations, that is a different story because, as of now, we have been neutral, avoiding promoting certain implementations over others. However, we could create a way for implementers to communicate that they seek new contributors by adding a new field to the tooling metadata.

@Honyii
Copy link

Honyii commented Jan 14, 2025

Due to the current direction to contributing guidelines for aspiring gsoc participants, can we have this pr merged if there is nothing else blocking it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants