Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The JSON Schema Charter #325
base: main
Are you sure you want to change the base?
The JSON Schema Charter #325
Changes from 20 commits
0b8d59b
4666a22
3cc72d2
b7de5e1
a4bf147
327b09e
cdc7cf5
d60d388
ece5e53
2d38695
29ed1a5
c9a6006
d0d58ba
0c0f97c
557c0a2
5abe1bd
9ba125a
9301be9
e3ecb1e
f6ac84c
a2af3ba
3fc951e
df8930a
cfa2ae9
a6bc2a8
d30322d
fea1163
14d7ca2
90896a9
dc3785a
c35d423
c1f0fa4
42e1c54
1b31445
9634a60
8f1df0f
f5dd0f5
d083f46
6653e46
c84610a
a4943cd
94d1801
c9ab2dd
b5f0e85
b2efdce
d2f853c
035ab9b
dc3e685
631db8c
8eb9883
341ecef
f4e35ff
e94c0cb
9e1ad26
52bedb3
4a2ad4a
397a8d1
d79198e
59deddb
f1974e2
c872a5f
a974117
86ff12e
55aa9b3
75542a8
aea0b80
fbe8b54
63cf673
a996e13
2a92249
58d942b
8b2ed66
be38006
4c92fc6
507246b
26f9265
31d5f6e
47a0d79
37eccb2
bea5924
91d5133
cdce30b
06240f9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to "reliable use of data expressed in the JSON format, other formats compatible with the JSON document model". JSON Schema isn't about the JSON data format itself, but about describing data expressed with that format, as well as others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While initially thinking about this, I thought I agreed, however on reflection, I'm not sure I do. It's not in scope of JSON Schema to care about other languages which "compile" to JSON, such as YAML.
I think this is only partially true. JSON Schema can only cater to a subset of YAML for example. It's possible to roundtrip from JSON to YAML to JSON, but not always possible to roundtrip from YAML to JSON to YAML.
The use of "JSON data format" was used in effort to convey the "in memory" materilization of the data, as opposed to just a JSON file.
I agree that "eliable use of data expressed in the JSON format" may make this clearer, however I'm not convinced about "other formats compatible with the JSON document model". "compatible" in what way?
Do you have any additional thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the existing wording focuses on the JSON format itself, suggesting that we're doing syntax checking of JSON files. But actually, we're starting with a presumption of valid JSON, and working with data presented in that format instead.
How about "data presented in the JSON format"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"data that can be expressed in the JSON format"? We're built on the data model, and I think this opens it up to other formats that are translatable to JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove OpenJSF
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd encourage you to make those sessions public all the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the intent! Public as much as possible!
I note that the CPC has a private portion of the call on occasion, for whatever reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whereby I meant that the session should be public by default (with an agenda and videoconf link made available upfront), not that it is private by default and that the TSC may decide to open it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. That is what is intended. If it doesn't come across that way, it needs revising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sentence is correct. It should be specified somewhere else that there might a private portion of the meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, but the problem of making allowing access to the TSC meeting at the discretion of the TSC, is that this makes the meeting private by default, and requires action by the TSC to make it public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't say that. It says the TSC may invite people to the public portion of the meeting. You're reading into it something which isn't there.
Technically, as it is public, and the details of how to access it will be public, anyone could invite anyone. But I wanted to make it explicit that TSC may invite guests.
I don't recall specifically where I borrowed the phrasing from, but I agree it is not clear and can be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont doubt your intentions. I’m stating that the text doesn’t match them. ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any restrictions on the maximum percentage of Governing Body members that can be employed by the same company? The risk of one company exerting undue influence over the direction of the project is real.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We looked at this before, I but I don't remember (or necessarily agree with) why it was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clause was seen more as a governance concern than a charter related concern, and was moved out to #456, specifically this line. (This also allows us to update it without having to go back to the OpenJS Foundation for their approval.)
I hear you. Regardless of what anyone in such a position reports, such as no to little influence, that doesn't mean things can't change, or it shouldn't be a concern.
We are trying to start addressing this by engaging more with implementers: #412 - Comments and suggestions welcome.
Additionally, we are looking to encourage users to self report: #441
Further, there are plans to create a stakeholders group: https://github.com/orgs/json-schema-org/projects/12/views/5 (Although these are a little vague currently).
Open to thoughts, suggestions, comments, on all of this and anything else that comes to mind as to how we can expand our TSC. @karenetheridge your voice carries weight here =]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this presents an immediate problem anymore, but I do think it's still a good idea to have such a limitation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest: