opentripplanner#52 Code review

src/main/java/org/opentripplanner/client/OtpApiClient.java

@@ -143,18 +143,12 @@ public Stop stop(String gtfsId) throws IOException {
     return deserialize(jsonNode, "/data/stop", Stop.class);
   }
 
-  public List<Stop> stops(String nameMask) {
+  public List<Stop> stops(String nameMask) throws IOException {
     var stopQuery = GraphQLQueries.stops();
     var formattedQuery = stopQuery.formatted(nameMask);
 
-    try {
-      final var jsonNode = sendRequest(formattedQuery);
-      var type = listType(Stop.class);
-      return deserializeList(jsonNode, type, "/data/stops");
-    } catch (IOException e) {
-      LOG.error("Could not fetch stops with name mask '{}'", nameMask, e);
-      return List.of();
-    }
+    final var jsonNode = sendRequest(formattedQuery);
+    return deserializeList(jsonNode, listType(Stop.class), "/data/stops");
   }
 
   private <T> T deserialize(JsonNode jsonNode, String path, Class<T> clazz) throws IOException {

src/main/java/org/opentripplanner/client/model/Stop.java

@@ -8,7 +8,7 @@ public record Stop(
     String name,
     @JsonProperty("gtfsId") String id,
     Optional<String> code,
-    Optional<String> vehicleMode,
+    Optional<VehicleMode> vehicleMode,
     Optional<String> zoneId,
     ParentStation parentStation) {
   public Stop {

src/main/java/org/opentripplanner/client/model/VehicleMode.java

@@ -0,0 +1,28 @@
+package org.opentripplanner.client.model;
+
+public enum VehicleMode {
+    AIRPLANE,
+    BICYCLE,
+    BUS,
+    CABLE_CAR,
+    CAR,
+    COACH,
+    FERRY,
+    FLEX,
+    @Deprecated
+    FLEXIBLE,
+    FUNICULAR,
+    GONDOLA,
+    @Deprecated
+    LEG_SWITCH,
+    RAIL,
+    SCOOTER,
+    SUBWAY,
+    TRAM,
+    CARPOOL,
+    TAXI,
+    TRANSIT,
+    WALK,
+    TROLLEYBUS,
+    MONORAIL
+}

src/main/resources/queries/stop.graphql

@@ -6,7 +6,9 @@ query {
         vehicleMode
         zoneId
         parentStation {
-            gtfsId name code
+            gtfsId
+            name
+            code
         }
     }
 }

src/main/resources/queries/stops.graphql

@@ -6,7 +6,9 @@ query {
         vehicleMode
         zoneId
         parentStation {
-            gtfsId name code
+            gtfsId
+            name
+            code
         }
     }
 }