fix: [develop] fix android jank ui when returnImage is true #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yujune
changed the title
yujune
changed the title
navaronbracke
requested changes
Jan 20, 2025
| import java.io.ByteArrayOutputStream | ||
| import java.io.IOException | ||
| import kotlin.math.roundToInt | ||
|
|
There was a problem hiding this comment.
Can you restore the blank line here?
|
@yujune Can you add a changelog entry for this fix? |
|
@yujune I think we want this change for the master branch (as a new version 6.0.x hotfix) and for the version 7.0.0 beta. |
navaronbracke
changed the title
navaronbracke
approved these changes
Jan 20, 2025
|
cc @juliansteenbakker for coordinating this change on dev with the cherry pick on master. |
juliansteenbakker
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What's the context?
When returnImage is set to true, android device experiences UI Jank when QR code is detected.
scanner_jank.mp4
🛠 Changes being made