feat: add pause feature #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! I don't yet have time for a full review (I will see if I can get that sorted in the coming week), but could you look into the following as well?
|
|
Thanks for your reply. |
|
@navaronbracke I implemented pause for MacOS and web. |
|
Any update on this? |
# Conflicts: # ios/Classes/MobileScanner.swift # macos/mobile_scanner/Sources/mobile_scanner/MobileScannerPlugin.swift
|
Thank you for your work, and my apologies for the late response. Lets get this merged! |
juliansteenbakker
merged commit b4a084c
into
juliansteenbakker:master
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #195
This PR introduces a pause feature.
pause() method stops the camera, but does not release the texture.
And It takes the following state transitions.
stateDiagram-v2 [*] --> Start Start --> Pause Pause --> Start Pause --> Stop Start --> Stop Stop --> [*]If this feature is useful and fits the concept of this library, please consider merging it.