Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split dynamic slippage file into 2 separate ones #27

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

boxme
Copy link
Collaborator

@boxme boxme commented Jan 22, 2025

Problem

  • One single json which contains 2 concepts and it's confusing to folks that it's also responsible for intermediate token hoping
  • Verified and default token categories are not useful and don't mean anything
  • Solana is lumped together with LST which causes routing to use other LSTs when users swap stables to solana

Solution

  • Split the files into 2.
    • token_categories: this houses the mints which we use for hoping
    • slippage_config: slippage min max. This will be used in RTSE as guardrail for the slippage we return
  • Remove verified category

@boxme boxme requested review from BingHuang-Chin, AaronCQL and 0xYankee-Raccoons and removed request for AaronCQL January 22, 2025 04:28
{
"name": "bluechip",
"mints": [
"JUPyiwrYJFskUPiHa7hkeR8VUtAeFoSYbKedZNsDvCN",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not 69 yet? can we run it once and merge the latest?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this first? I need the URL for the other work

@boxme boxme merged commit 7a0b3ad into main Jan 22, 2025
1 check passed
@boxme boxme deleted the feat/slip_config_files branch January 22, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants