Fix build with hatch by specifying folder name explicitly #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/fix-build
branch
from
f67a5d5 to
f9c34b4
Compare
pnasrat
added a commit
to wolfi-dev/os
that referenced
this pull request
Oct 3, 2024
See: jupyterhub/kubespawner#818 Signed-off-by: Pris Nasrat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this resolves at least a part of #816.
I think something changed over time even though I don't find a clear entry in a changelog. Looking at https://hatch.pypa.io/latest/plugins/builder/wheel/#default-file-selection and seeing how @martinclaus resolved this in jupyterhub/ltiauthenticator#185 I went with this change.