tests: Convert PORT envvar to int to fix aiohttp/yarl compatibility
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conver the value of the `PORT` environment variable to int, to fix incompatibility with modern versions of aiohttp/yarl, that do expect the `port` argument to be one. Fixes jupyterhub#49
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
Congrats on your first merged pull request in this project! 🎉 |
consideRatio
changed the title
PORT envvar to int to fix aiohttp/yarl compatibilityPORT envvar to int to fix aiohttp/yarl compatibility
|
Wieee thank you @mgorny!!! ❤️ 🎉 🌻 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conver the value of the
PORTenvironment variable to int, to fix incompatibility with modern versions of aiohttp/yarl, that do expect theportargument to be one.Fixes #49