-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dummy service accounts to hook-image-puller and continuous-image-puller pods #3594
base: main
Are you sure you want to change the base?
Conversation
jupyterhub/templates/image-puller/serviceaccount-continuous.yaml
Outdated
Show resolved
Hide resolved
jupyterhub/templates/image-puller/serviceaccount-continuous.yaml
Outdated
Show resolved
Hide resolved
I'm super low on time, but lets try this - do your best to address the review comments, and i'll try get it through to a merge by finishing details this weekend. Details if you want to try work those as well, from the top of my head would include:
|
Thanks for the feedback, I will address everything today. |
…yterhub-k8s into ft-labels-hub
jupyterhub/templates/image-puller/serviceaccount-continuous.yaml
Outdated
Show resolved
Hide resolved
Tests are failing since https://mybinder.org/ is down. |
@samyuh great work! I pushed two detail commits. @manics do you have time for a quick gut-check evaluation? This PR adds two dummy service accounts to be used by the the image-puller pods to please various security checks as discussed in #3545 (comment). Do we make them enabled by default, or not? I'm leaning towards enabled by default to reduce the hassle for anyone needing to comply with these benchmarks etc, but I'm not fully confident it has no drawbacks for users in other situations. |
Thanks for your effort and your review! |
This MR adds two separate dummy ServiceAccounts for hook-image-puller and continuous-hook-image-puller.
Closes #3545