Add gas to post-reads, make module admin acquisition explicit. #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcardon
force-pushed
the
jose/gas-v3
branch
5 times, most recently
from
081e059 to
6b811ab
Compare
rsoeldner
approved these changes
Sep 3, 2024
| -> BuiltinEnv e b i | ||
| -> CapToken FullyQualifiedName PactValue | ||
| -> CapToken QualifiedName PactValue |
There was a problem hiding this comment.
Why are we moving from FQN to QN, especially as we need fqn (see line 1686).?
There was a problem hiding this comment.
Great question, it's because this is particularly so the API is easier to use. This is generally called by chainweb to call something like evaluating something within(some_module.GAS_PAYER args). We don't want our caller to have to deal with getting the fully qual name themselves
pact/Pact/Core/IR/Eval/CEK/Utils.hs
Outdated
| @@ -94,7 +94,7 @@ sysOnlyEnv e | |||
| let newPactdb = | |||
| PactDb | |||
| { _pdbPurity = PSysOnly | |||
| , _pdbRead = read' | |||
| , _pdbRead = \dom k -> read' dom k | |||
jmcardon
force-pushed
the
jose/gas-v3
branch
from
80922c6 to
2d4916a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist:
Additionally, please justify why you should or should not do the following: