Pulls in fix for update API #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <[email protected]>
Signed-off-by: Chengxuan Xing <[email protected]>
Only the org DID is needed for this check - no need to actually look up the org from the database. At this point the message author has already been verified, so a database lookup here is just extra unnecessary processing (and can lead to infinite retries if it fails). Signed-off-by: Andrew Richardson <[email protected]>
Do not expect to retrieve local org during definition handling
…do-io/firefly into enterprise-update-api
…ate-bug-for-unpublished
…do-io/firefly into enterprise-update-api
matthew1001
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Looks fine and matches that PR approved by @awrichar in hyperledger#1395
I note that PR hasn't merged yet, but I'm assuming there are no other changes pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picks up hyperledger#1395 for https://github.com/kaleido-io/kaleido-kap-planning/issues/1241