Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/configurable timeout #385

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

smessmer
Copy link
Contributor

Fixes #382

  • cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@Firstyear Firstyear merged commit c70b1bb into kanidm:master Nov 14, 2023
31 of 33 checks passed
@Firstyear
Copy link
Member

Thank you @smessmer !

@micolous
Copy link
Collaborator

This broke the documentation build:

  Documenting webauthn-attestation-ca v0.1.0 (/home/runner/work/webauthn-rs/webauthn-rs/attestation-ca)
error: unresolved link to `webauthn_rs_core::constants::DEFAULT_AUTHENTICATOR_TIMEOUT`
   --> webauthn-rs/src/lib.rs:323:34
    |
323 |     /// If not set, defaults to [webauthn_rs_core::constants::DEFAULT_AUTHENTICATOR_TIMEOUT].
    |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `constants` in module `webauthn_rs_core`
    |
note: the lint level is defined here
   --> webauthn-rs/src/lib.rs:170:9
    |
170 | #![deny(warnings)]
    |         ^^^^^^^^
    = note: `#[deny(rustdoc::broken_intra_doc_links)]` implied by `#[deny(warnings)]`

error: could not document `webauthn-rs`

webauthn_rs_core::constants is not public, so you can't reference it in webauthn-rs.

micolous added a commit that referenced this pull request Nov 23, 2023
micolous added a commit to micolous/webauthn-rs that referenced this pull request Nov 24, 2023
This fixes a documentation build breakage caused by kanidm#385, and shifts
default timeouts into our recommended interface.
@micolous micolous mentioned this pull request Nov 24, 2023
2 tasks
micolous added a commit to micolous/webauthn-rs that referenced this pull request Nov 24, 2023
This fixes a documentation build breakage caused by kanidm#385, and shifts
default timeouts into our recommended interface.
Firstyear pushed a commit that referenced this pull request Nov 24, 2023
* Move `DEFAULT_AUTHENTICATOR_TIMEOUT` into `webauthn-rs`.

This fixes a documentation build breakage caused by #385, and shifts
default timeouts into our recommended interface.

* Add PhantomData to stubs with type parameters, to fix a build issue on nightly

* fix softtoken

* Fix softpasskey

* Update timeouts per Webauthn-3 recommendation, and add verbiage
kikuomax pushed a commit to codemonger-io/webauthn-rs that referenced this pull request Nov 24, 2024
kikuomax pushed a commit to codemonger-io/webauthn-rs that referenced this pull request Nov 24, 2024
* Move `DEFAULT_AUTHENTICATOR_TIMEOUT` into `webauthn-rs`.

This fixes a documentation build breakage caused by kanidm#385, and shifts
default timeouts into our recommended interface.

* Add PhantomData to stubs with type parameters, to fix a build issue on nightly

* fix softtoken

* Fix softpasskey

* Update timeouts per Webauthn-3 recommendation, and add verbiage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable Timeout
3 participants