Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH PR parser - Use links in markdown for funders #1439

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Gustry
Copy link
Contributor

@Gustry Gustry commented Aug 31, 2022

It happens often. This test case should be covered.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1439 (ba900fe) into develop (b9fc0ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1439   +/-   ##
========================================
  Coverage    64.22%   64.22%           
========================================
  Files          179      179           
  Lines         8800     8800           
  Branches      1258     1258           
========================================
  Hits          5652     5652           
  Misses        2866     2866           
  Partials       282      282           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Gustry
Copy link
Contributor Author

Gustry commented Aug 31, 2022

Ah, tests are already passing ?
But the logs in the GH Action shows it failed !
https://github.com/kartoza/prj.app/runs/8111351705?check_suite_focus=true#step:8:932

@dimasciput This looks dangerous FYI.

@dimasciput
Copy link
Member

@Gustry thanks for noticing, I will check this issue when I'm back from leave. Did you make this PR while resting from your bike trip? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants