This repository has been archived by the owner on Jan 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 133
Time remaining hover text #6
Open
Furfx
wants to merge
20
commits into
kas:master
Choose a base branch
from
Furfx:TimeRemainingHoverText
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed manifest related properties in percentage.csproj so it can compile everywhere Replaced the hover text by the estimated remaining battery time or by "Charging" if the laptop is connected to a power source
Removed the manifest properties (again) to allow compilation by everyone
PsiHovno
suggested changes
Feb 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. I'm really noob in this but is it possible to add the percentage (%) symbol next to the numbers? It would be really cool if it could have that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have found your project as I was looking to replace the useless Windows 10 battery icon by something light and practical. Your idea is really good and I saw an opportunity to make some improvements, so here they are.
I made the following modifications :
The hover text now shows the estimated time remaining or just 'Charging' if the laptop is plugged to a power source (instead of x%). The values are exactly the same as displayed by the W10 battery icon. I am looking to change this 'Charging' by the the time it takes to fully charge the battery but I didn't find a way (yet).
The background of the tray icon is now transparent instead of black.
In the file 'percentage.csproj' I removed everything related to the manifest to allow everyone to compile the project.
Thank you for your software and have a nice day :)