mypy

taca/element/Element_Runs.py

@@ -385,7 +385,7 @@ def find_lims_zip(self) -> str | None:
             lims_zip_src_path = glob_results[0]
         return lims_zip_src_path
 
-    def copy_manifests(self, zip_src_path) -> bool:
+    def copy_manifests(self, zip_src_path):
         """Fetch the LIMS-generated run manifests from ngi-nas-ns and unzip them into a run subdir."""
         # Make a run subdir named after the zip file and extract manifests there
 

tests/element/test_Element_Runs.py

@@ -158,30 +158,6 @@ def test_get_demultiplexing_status(
 
         assert run.get_demultiplexing_status() == p["expected"]
 
-    @pytest.mark.skip(reason="Not implemented yet")
-    @pytest.mark.parametrize(
-        "p",
-        [
-            {"run_finished": True, "expected": True},
-            {"run_finished": False, "expected": False},
-        ],
-        ids=["exists", "does not exist"],
-    )
-    def test_manifest_exists(
-        self, mock_db: mock.Mock, create_dirs: pytest.fixture, p: pytest.fixture
-    ):
-        tmp: tempfile.TemporaryDirectory = create_dirs
-
-        run = to_test.Run(
-            create_element_run_dir(
-                tmp,
-                run_finished=p["run_finished"],
-            ),
-            get_config(tmp),
-        )
-
-        assert run.manifest_exists() == p["expected"]
-
     @pytest.mark.skip(reason="Not implemented yet")
     def test_generate_demux_command(self, mock_db):
         pass