Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): Investigate ManagedTableDataset test failures #671

Merged

Conversation

SajidAlamQB
Copy link
Contributor

@SajidAlamQB SajidAlamQB commented May 8, 2024

Description

Related to: #399

ManagedTableDataset tests were failing with this error:

AttributeError: 'DataFrame' object has no attribute 'iteritems'. Did you mean: 'items'?

This error occurred because the iteritems() method was removed in pandas version 2.0. See https://stackoverflow.com/questions/75926636/databricks-issue-while-creating-spark-data-frame-from-pandas

Development notes

To solve this issue, I added a single line to create an alias for the items() method.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

@SajidAlamQB SajidAlamQB changed the title test fix(datasets) Investigate ManagedTableDataset test failures May 8, 2024
@SajidAlamQB SajidAlamQB changed the title fix(datasets) Investigate ManagedTableDataset test failures fix(datasets): Investigate ManagedTableDataset test failures May 22, 2024
SajidAlamQB and others added 22 commits May 22, 2024 14:54
Signed-off-by: Sajid Alam <[email protected]>
https://github.com/kedro-org/kedro-plugins into bugfix/fix-spark-test-failure-for-ManagedTableDataset

Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
@SajidAlamQB SajidAlamQB self-assigned this Jun 6, 2024
@SajidAlamQB SajidAlamQB marked this pull request as ready for review June 6, 2024 14:55
@SajidAlamQB SajidAlamQB requested review from merelcht and ankatiyar June 6, 2024 14:57
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @SajidAlamQB 👏

@SajidAlamQB SajidAlamQB merged commit 297a648 into main Jun 6, 2024
54 checks passed
@SajidAlamQB SajidAlamQB deleted the bugfix/fix-spark-test-failure-for-ManagedTableDataset branch June 6, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants