-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datasets): Investigate ManagedTableDataset test failures #671
Merged
SajidAlamQB
merged 34 commits into
main
from
bugfix/fix-spark-test-failure-for-ManagedTableDataset
Jun 6, 2024
Merged
fix(datasets): Investigate ManagedTableDataset test failures #671
SajidAlamQB
merged 34 commits into
main
from
bugfix/fix-spark-test-failure-for-ManagedTableDataset
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SajidAlamQB
changed the title
test
fix(datasets) Investigate ManagedTableDataset test failures
May 8, 2024
…leDataset Signed-off-by: Sajid Alam <[email protected]>
SajidAlamQB
changed the title
fix(datasets) Investigate ManagedTableDataset test failures
fix(datasets): Investigate ManagedTableDataset test failures
May 22, 2024
Signed-off-by: Sajid Alam <[email protected]>
https://github.com/kedro-org/kedro-plugins into bugfix/fix-spark-test-failure-for-ManagedTableDataset Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
https://github.com/kedro-org/kedro-plugins into bugfix/fix-spark-test-failure-for-ManagedTableDataset Signed-off-by: Sajid Alam <[email protected]>
ankatiyar
approved these changes
Jun 6, 2024
merelcht
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @SajidAlamQB 👏
SajidAlamQB
deleted the
bugfix/fix-spark-test-failure-for-ManagedTableDataset
branch
June 6, 2024 16:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: #399
ManagedTableDataset
tests were failing with this error:AttributeError: 'DataFrame' object has no attribute 'iteritems'. Did you mean: 'items'?
This error occurred because the
iteritems()
method was removed in pandas version 2.0. See https://stackoverflow.com/questions/75926636/databricks-issue-while-creating-spark-data-frame-from-pandasDevelopment notes
To solve this issue, I added a single line to create an alias for the
items()
method.Checklist
RELEASE.md
file