Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datasets): replace "data set" with "dataset" #867

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

deepyaman
Copy link
Member

Description

Better adhere to the Kedro lexicon.

@deepyaman deepyaman force-pushed the chore/datasets/replace-data-set branch from 813d7a3 to 6053eed Compare October 10, 2024 14:38
@noklam noklam self-requested a review October 10, 2024 14:40
Signed-off-by: Ankita Katiyar <[email protected]>
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted one of the changes in pandas/test_gbq_dataset.py which was intentionally "data set"

@deepyaman deepyaman merged commit 987dab9 into main Oct 10, 2024
12 checks passed
@deepyaman deepyaman deleted the chore/datasets/replace-data-set branch October 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants