Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(datasets): Move to linkcode extension #985

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Jan 13, 2025

Description

Related kedro-org/kedro#4174
Related PR kedro-org/kedro#4410

Development notes

Docs build for this PR - https://kedro--985.org.readthedocs.build/projects/kedro-datasets/en/985/
Please check by going to API docs and clicking on "[source]"

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

Signed-off-by: Ankita Katiyar <[email protected]>
@ankatiyar ankatiyar marked this pull request as ready for review January 13, 2025 14:41
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Copy link
Contributor

@ElenaKhaustova ElenaKhaustova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ankatiyar ankatiyar merged commit 6f0ffa9 into main Jan 13, 2025
13 checks passed
@ankatiyar ankatiyar deleted the datasets/docs/linkcode branch January 13, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants