Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set base_env and default_run_env in settings.py #186

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Explicitly set base_env and default_run_env in settings.py #186

merged 3 commits into from
Nov 22, 2023

Conversation

merelcht
Copy link
Member

Motivation and Context

Same change as kedro-org/kedro#3326 but then for starters.

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@merelcht merelcht marked this pull request as ready for review November 22, 2023 15:36
@merelcht merelcht self-assigned this Nov 22, 2023
astrojuanlu
astrojuanlu approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@merelcht merelcht merged commit 5029e57 into main Nov 22, 2023
1 check passed
@merelcht merelcht deleted the update-settings-explicit-envs branch November 22, 2023 16:05
@merelcht merelcht mentioned this pull request Nov 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SajidAlamQB SajidAlamQB SajidAlamQB approved these changes

@DimedS DimedS DimedS approved these changes

@astrojuanlu astrojuanlu astrojuanlu approved these changes

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merelcht @astrojuanlu @DimedS @SajidAlamQB