-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce behaviour
prop object with reFocus
prop
#2161
Changes from 6 commits
cbb35d2
3e8101a
07e2ebf
97f9918
be54fa5
6f3166f
d52cdc9
53e9c45
b8d1cf1
f04975d
d62a6f6
c8e343e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,7 @@ const combinedReducer = combineReducers({ | |
// These props don't have any actions associated with them | ||
display: createReducer(null), | ||
dataSource: createReducer(null), | ||
modeOptions: createReducer({}), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Nit] modeOptions inside options seems a bit confusing to me. Was there any consideration of having reFocus inside display ? If not, was there any reason to separate this ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if we expand on how flowchart behaves, something like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ravi-kumar-pilla There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hey since the stand-alone version primarily covers the flowchart, we might not need to specify 'flowchart.' Maybe something more general like |
||
edge: createReducer({}), | ||
// These props have very simple non-nested actions | ||
chartSize: createReducer({}, UPDATE_CHART_SIZE, 'chartSize'), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, it looks like this section of code is for different beahviour of the stand-alone app. Perhaps having a comment here could help clarify the purpose, so we'll have better context if we refactor this component in the future. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Huongg Not exactly, those condition is also being used in normal mode, but yes refactoring
flowchart.js
component will really help overall.