-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor modular pipeline expansions to instantly update UI #2225
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expand/collapse doesn't work with the NodeList in the sidebar.
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
…kedro-org/kedro-viz into introduce-manage-toolbarOptions Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
I noticed for the first time the toggle doesn't update the view instantly but subsequent presses do. |
yeah i noticed that too. |
Signed-off-by: Sajid Alam <[email protected]>
Fixed the |
Signed-off-by: Sajid Alam <[email protected]>
src/components/flowchart-primary-toolbar/flowchart-primary-toolbar.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
…pipelines Signed-off-by: Huong Nguyen <[email protected]>
Description
This PR updates the logic for determining which nodes are visible when toggling
expandAllPipelines
. Previously, modular pipeline expansions were applied once during initial start, requiring data reloads to see changes. Now, the visibility logic is integrated directly intodisabled.js
, allowing the UI to reflect state changes immediately.Checklist
RELEASE.md
file