-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the viz
add-ons to kedro new
#3228
Conversation
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
…into noklam/viz-add-on Signed-off-by: SajidAlamQB <[email protected]> Signed-off-by: SajidAlamQB <[email protected]>
…s.txt Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: Nok <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: Sajid Alam <[email protected]>
…into noklam/viz-add-on Signed-off-by: Nok <[email protected]>
The current test suite is still asserting text, we should read the parse the file. I think this should be merged first #3230. There are not much points to fix the broken test if we are gonna change that. |
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: Nok <[email protected]> Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Should https://github.com/kedro-org/kedro-starters/blob/main/spaceflights-pyspark/hooks/post_gen_project.py be updated to also mention "Kedro Viz" not in addons? The opposite of https://github.com/kedro-org/kedro-starters/blob/main/spaceflights-pandas-viz/hooks/post_gen_project.py |
Nice spot! I don't think it really matters as the templates are decided in |
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
…into noklam/viz-add-on Signed-off-by: SajidAlamQB <[email protected]> Signed-off-by: SajidAlamQB <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried this out and the behaviour looks good! I found a coupling between the existence of the data
folder and the SQLiteSessionStore
config, but let's decide on that via Slack.
The only thing that's missing is just the docstring for the helper methods, but happy to approve when that's done 👍
I have fix the tests with Documented my observation in #3264 |
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
Signed-off-by: SajidAlamQB <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @SajidAlamQB and @noklam ⭐ ⭐ ⭐
Signed-off-by: SajidAlamQB <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good to me! Good work refactoring the tests 🌟
"4": 2, | ||
"5": 8, | ||
"6": 3, | ||
"1": 0, # Linting does not add any files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart choice adding the comments!
Signed-off-by: Nok Lam Chan <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
Signed-off-by: Nok Chan <[email protected]>
Description
Fix #3074 and #3075
Development notes
@SajidAlamQB Notes:
utils.py
and unstrippedpyproject.toml
andrequirements.txt
. We now handle removing headers frompyproject.toml
using thetoml
library.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file