Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added node import to the pipeline template #4395

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

ElenaKhaustova
Copy link
Contributor

Description

Fixes #3557

Development notes

Added node import to kedro/kedro/templates/pipeline/{{ cookiecutter.pipeline_name }}/pipeline.py

Tried #3557 (comment) but ended up with just # noqa without adding a dummy pipeline as it breaks kedro run after the user run kedro pipeline create which might be confusing:

ValueError: Invalid Node definition: first argument must be a function, not 'ellipsis'.
Format should be: node(function, inputs, outputs)

If we want to add a dummy pipeline, we can also add a dummy node function, so the above error doesn't appear. However, I'm not sure how useful it is, so I left the template as it is.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
@ElenaKhaustova ElenaKhaustova marked this pull request as draft January 2, 2025 14:35
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
@ElenaKhaustova ElenaKhaustova marked this pull request as ready for review January 2, 2025 14:58
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ElenaKhaustova!

Copy link
Member

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ElenaKhaustova !

Signed-off-by: Elena Khaustova <[email protected]>
@ElenaKhaustova ElenaKhaustova enabled auto-merge (squash) January 2, 2025 15:23
@ElenaKhaustova ElenaKhaustova merged commit 70734ce into main Jan 2, 2025
39 of 40 checks passed
@ElenaKhaustova ElenaKhaustova deleted the fix/3557-add-node-import branch January 2, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro pipeline create pipeline.py with missing import
3 participants