Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for next version #233

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Prepare for next version #233

merged 2 commits into from
Nov 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 20, 2023

DO NOT MERGE YET! The smoke test failed. Please fix the problem before merging this PR which updates version numbers and prepares for release v1.78.0

UPDATE smoke test now passes - see comments before for details of what happened

@jmazzitelli
Copy link
Contributor

jmazzitelli commented Nov 20, 2023

[ERROR] The OSSMC image is not published on quay.io. This is missing: [quay.io/kiali/ossmconsole:v1.77.0]. The smoke test has FAILED!

It looks like OSSMConsole v1.77 was not released by the time the smoketest ran. I can see Kiali server and OSSMC were released by more than 30 minutes apart:

OSSMC: https://quay.io/repository/kiali/ossmconsole?tab=tags (1.77 released at 2:52 am EST)
Kiali: https://quay.io/repository/kiali/kiali?tab=tags (1.77 released at 2:18 am EST)

So we'll want to check this to see if there is someway we can get this helm chart release to run AFTER the OSSMConsole is released - because that is when the smoke test will run and that needs to confirm all images are available on quay.

Thinking about this some more - I'm pretty sure this is because it takes very long to do an OSSMC build (the yarn build and copying of the node_modules takes a very long time to complete - much longer than a kiali server or kiali operator build). So we will need to wait for that ossmc build to finish before we move on to the helm chart build, if that is possible.

@jmazzitelli
Copy link
Contributor

I will run the smoke test again and if it goes green (it should), I'll retitle this PR and merge it.

@jmazzitelli jmazzitelli reopened this Nov 20, 2023
@jmazzitelli
Copy link
Contributor

OK, smoke test passed. Will merge now.

@jmazzitelli jmazzitelli changed the title [DO NOT MERGE YET] Prepare for next version Prepare for next version Nov 20, 2023
@jmazzitelli jmazzitelli self-assigned this Nov 20, 2023
@jmazzitelli jmazzitelli merged commit 27907e2 into master Nov 20, 2023
2 checks passed
jmazzitelli added a commit to jmazzitelli/helm-charts that referenced this pull request Nov 20, 2023
jmazzitelli added a commit that referenced this pull request Nov 20, 2023
Matiasmct pushed a commit to giffgaff/kiali-charts-backup that referenced this pull request Nov 29, 2023
* Release v1.77.0

* Prepare for next version

---------

Co-authored-by: kiali-bot <[email protected]>
Matiasmct pushed a commit to giffgaff/kiali-charts-backup that referenced this pull request Nov 29, 2023
@jmazzitelli jmazzitelli deleted the helm-charts-release-104-main branch December 23, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant