be able to configure server liveness/readiness/startup probe

[jmazzitelli]

fixes: kiali/kiali#7832

[jmazzitelli]

to test, first "make build-helm-charts" and then...

configure with custom values:

 helm template -n istio-system --show-only templates/deployment.yaml --set deployment.readiness_probe.initial_delay_seconds=123 --set deployment.readiness_probe.period_seconds=456 kiali-server _output/charts/kiali-server-*.tgz 

you should see in the output:

        readinessProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 123
          periodSeconds: 456

then do not configure or set with empty string - see defaults take effect:

helm template -n istio-system --show-only templates/deployment.yaml --set deployment.readiness_probe.initial_delay_seconds= --set deployment.readiness_probe.period_seconds= kiali-server _output/charts/kiali-server-*.tgz 

and you should see in the output:

        readinessProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 5
          periodSeconds: 30

[jmazzitelli]

do not merge this - I think we need to change this to configure the startup probe, not the readiness probe (based on the github issue description of why this is needed)

[jmazzitelli]

latest commit lets you config some or all three probes - because you just know SOMEBODY somewhere is going to want to configure one of the other ones (not just readiness).

to test that you can configure all three:

helm template -n istio-system --show-only templates/deployment.yaml --set deployment.probes.readiness.initial_delay_seconds=11 --set deployment.probes.readiness.period_seconds=22 --set deployment.probes.liveness.initial_delay_seconds=33 --set deployment.probes.liveness.period_seconds=44 --set deployment.probes.startup.initial_delay_seconds=55 --set deployment.probes.startup.period_seconds=66 --set deployment.probes.startup.failure_threshold=77 kiali-server _output/charts/kiali-server-*.tgz

and you should see this:

        readinessProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 11
          periodSeconds: 22
        livenessProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 33
          periodSeconds: 44
        startupProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 55
          periodSeconds: 66
          failureThreshold: 77

[jmazzitelli]

when you don't set them - the defaults are:

        readinessProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 5
          periodSeconds: 30
        livenessProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 5
          periodSeconds: 30
        startupProbe:
          httpGet:
            path: /kiali/healthz
            port: api-port
            scheme: HTTP
          initialDelaySeconds: 30
          periodSeconds: 10
          failureThreshold: 6

[jshaughn]

Nerd, I was just playing around to see if I could better understand this stuff :-) Probably my lack of expertise hurt your eyes.