Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase signing key length #303

Merged
merged 1 commit into from
Dec 17, 2024
Merged

increase signing key length #303

merged 1 commit into from
Dec 17, 2024

Conversation

jmazzitelli
Copy link
Contributor

No description provided.

@jmazzitelli jmazzitelli self-assigned this Dec 16, 2024
@jmazzitelli
Copy link
Contributor Author

To test, build the helm charts and run "helm template" and see the generated (and random) signing_key now has a length of 32:

make build-helm-charts && helm template kiali-server _output/charts/kiali-server-*.tgz | grep signing_key

should return something like:

      signing_key: ipK0gNDt21nGujPwzivZZbKudF9dIGDY

Confirm that new random string is 32 characters long.

@jmazzitelli jmazzitelli marked this pull request as ready for review December 16, 2024 19:16
@jshaughn jshaughn self-requested a review December 17, 2024 00:33
Copy link

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@jshaughn jshaughn merged commit 9d8a68d into kiali:master Dec 17, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the key-size branch December 17, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants