Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to configure Kiali with remote cluster secrets. #718

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli commented Nov 16, 2023

Netlify link: https://deploy-preview-718--kiali.netlify.app/docs/configuration/multi-cluster/#setup

fixes: kiali/kiali#6851

(Side note: I changed the Kiali CR "installation guide" page so it uses the same annotation as the "new namespace" playbook. It is best to keep them consistent.)

Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 37 to 40
{{% alert color="info" %}}
If you wish to delete a remote cluster secret that was previously created by that script, pass in the command line option `--delete true` to the script along with the same command line options you passed in when creating the secret. Use the option `--help` for additional details on using the script to create and delete remote cluster secrets.
{{% /alert %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than this and the other info alert being separate notes in the middle of the "setup" section, I think it would be easier for someone to find if removing a cluster was its own section like "cleanup" or just "removing a cluster" etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if removing a cluster was its own section like "cleanup" or just "removing a cluster" etc.

this is done

fixes: kiali/kiali#6851

(Side note: I changed the Kiali CR "installation guide" page so it uses
the same annotation as the "new namespace" playbook.
It is best to keep them consistent.)
@jmazzitelli jmazzitelli merged commit 2e418cb into kiali:staging Nov 20, 2023
4 checks passed
@jmazzitelli jmazzitelli deleted the 6851-mc-docs branch November 20, 2023 20:52
hhovsepy pushed a commit to hhovsepy/kiali.io that referenced this pull request Apr 5, 2024
* Document how to configure Kiali with remote cluster secrets.
fixes: kiali/kiali#6851

(Side note: I changed the Kiali CR "installation guide" page so it uses
the same annotation as the "new namespace" playbook.
It is best to keep them consistent.)

* introduce a remove cluster section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Multicluster - Document how to "remove" a cluster
3 participants