Switch all functions to run synchronously #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all asynchronous functionality from the library.
Feel free to not merge, if it's not something you want to implement. I'm sure you had your reasons for going fully asynchronous (performance?). For myself, I'm setting up a custom integration with your (great) library which integrates directly into my
app.config.ts
, but this library doesn't play well because the configuration cannot return a promise, and cannot resolve as a module (meaning no top-level asynchronous functionality).I'll re-release this under my own namespace for personal use, and switch it over if you decide to merge this in. c:
Note, this would constitute a major version bump.