Fix maybe initialized warning in httplib. #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch has been send upstream : yhirose/cpp-httplib#1085
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 66.14% 66.14%
=======================================
Files 53 53
Lines 3819 3819
Branches 1933 1914 -19
=======================================
Hits 2526 2526
Misses 1291 1291
Partials 2 2 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR somehow supersedes #633
#633 fix the issue on httplib but also update to last version of httplib. But with the last version of httplib our tests are not working anymore. We have to investigate this.
But let's merge the patch right now as it is needed to compile libkiwix on recent linux (#632)
Patch has been send upstream :
yhirose/cpp-httplib#1085